Repository navigation
test(apphost): cover the observability metric sources, manifest file and Prometheus renderer - #7529
Merged
Merged
Conversation
…rometheus renderer Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Author
|
The red Newman API Test Suite check is not caused by this PR. It fails at the step "PHPUnit unit suite (in-container, HARD GATE)". That step currently fails on every PR, including JS-only ones such as #7510.
The 39 extra tests are exactly this PR's new tests, and they all pass. The failing tests are No fix exists yet; it belongs in its own PR. #7519 has the details. Generated by Claude Code |
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49074/49084 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 14:02 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIG coverage round t1, lane T04: PHP unit tests for AppHost observability.
What this covers
This PR adds new test files only; no production code changes. The new files carry no
@coversor#[CoversClass]annotations.phpunit.xmlsetsbeStrictAboutCoverageMetadata=true, and that setting is why the existing MetricsEngine tests record ~0 for these sources: they are marked risky, so their coverage is discarded.Left uncovered:
BundledManifestFile.php:76, thefile_get_contentsfalse-after-is_readablereturn. Reaching it needs a production seam, an injectable reader. Forcing that failure in a test raises a PHP warning inside production code, andfailOnWarningturns that warning into a failure.What ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover /tmp/obs.xml --filter '<the 5 new test classes>' tests/Unit/AppHost/Observability: OK (39 tests, 105 assertions), 0 risky. It is a subset run, so the coverage above is a lower bound.weak.phpovertests/Unit/AppHost/Observabilityflags none of the new files.now,today) are asserted between timestamps taken just before and just after the call, so the tests do not depend on the clock.Mutation samples (each reverted)
$value === 0 || $value === 0.0->$value === 0-> 1 test failed['ne' => $resolved]->$resolved-> 1 test failed$sample instanceof MetricSample->true-> 1 test failedexpr()->lte->expr()->lt-> 1 test failed|| is_array($decoded) === false-> 1 test errored'_' . $safeKey->$safeKey-> 1 test failedThe tests were written with Claude Code.
Generated by Claude Code